Well let's see... get comfortable everyone... it was a dark and stormy night...
When I first installed that new pump the engine went from not idling at all to a nice, smooth fast idle. I blipped the throttle to slow it down and it settled into a higher than normal smooth idle. I backed off the idle screws a turn and everything was great. Later, I went to start it again and it was back to the way it was- no idle but give it gas and it revs. Turn the idle screws in to get it to idle and it kind of fluctuates between rough and almost dying.
I measured the pump push rod and it's about 1mm short so I have one on order. In the meantime and sanded down my extra spacer about 2mm with no improvement.
The pump pictured is one I bought at the outset of this project assuming it was an exact replacement for the smooth (no screws) original. After the fitment issue I did some searching and found one HBChris had suggested (I got it off of Ebay for less but this link might last longer)-
https://www.autosurplus.com.au/bmw-2800-3.0s-3.0cs-3.0csl-525-mechanical-fuel-pum
This one fits a little better but no improvement in running. Three pumps, all the same.
I've now moved on to the carbs. Replaced the float needles, checked float height, replaced all rubber lines going back to the tank, tried running it with/without fuel cap (no rush of air), and looked at the sender- seems fine.
Could be a vacuum leak but I used hylomar blue on the spacers and replaced the throttle shaft seals with tiny little bearing sets with no improvement.
I'm still waiting on my driveshaft so this all is being done an hour here, an hour there.